Skip to content

Share re-defined defineReadOnlyGlobal(...)#42801

Closed
christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer:export-D53340274
Closed

Share re-defined defineReadOnlyGlobal(...)#42801
christophpurrer wants to merge 1 commit intofacebook:mainfrom
christophpurrer:export-D53340274

Conversation

@christophpurrer
Copy link
Copy Markdown
Contributor

@christophpurrer christophpurrer commented Feb 2, 2024

Summary:
Fixes some tech debug

Changelog: [Fixed] Share re-defined defineReadOnlyGlobal(...)

Differential Revision: D53340274

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 2, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@analysis-bot
Copy link
Copy Markdown

analysis-bot commented Feb 2, 2024 •
edited
Loading

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,922,790 +20,480
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 21,276,960 +20,480
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 046f664
Branch: main

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 2, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 4, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@christophpurrer @facebook-github-bot
Share re-defined defineReadOnlyGlobal(...) (facebook#42801)
55c910f 
Summary:

Fixes some tech debug

Changelog: [Internal] [Fixed] Share re-defined defineReadOnlyGlobal(...)

Reviewed By: javache

Differential Revision: D53340274
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request was exported from Phabricator. Differential Revision: D53340274

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label Feb 19, 2024
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Feb 19, 2024

This pull request has been merged in 28da7f9.

@vmoroz
Copy link
Copy Markdown
Contributor

vmoroz commented Mar 28, 2024

@christophpurrer, could you please rename the new files?
ReactCommon already has jsi.h and jsi.cpp files.
MSVC does not allow to have two files with the same name in the same project.
We have no way to use these new files in our react-native-windows project.
Ideally all files in the same project must have unique name regardless of their folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@christophpurrer @facebook-github-bot @analysis-bot @vmoroz
⚡